newaccount.php

[matt_t_hat]

Can I just ask what the thinking was with this snippit? It seems a bit unusual to global the manager after you have used it once already.

Code: Select all

      <?php
      // add extra fields from Plugins, like NP_Profile
      $manager->notify('RegistrationFormExtraFields', array('type' => 'createaccount.php', 'prelabel' => '', 'postlabel' => '<br />', 'prefield' => '', 'postfield' => '<br /><br />'));
      // add a Captcha challenge or something else
      global $manager;
      $manager->notify('FormExtra', array('type' => 'membermailform-notloggedin'));
      ?>

I'm sure there is some sound logic for it but I can't see it just currently.

[ftruscot]

Probably a remnant of a cut and paste from somewhere else. It's likely not needed as it is already declared global somewhere above the first call to $manager->notify()

[matt_t_hat]

Probably a remnant of a cut and paste from somewhere else. It's likely not needed as it is already declared global somewhere above the first call to $manager->notify()

That's what I thought. Do we have an unstable branch I can check-out of SVN (or whatever) I'm thinking it might be time for me to offer some actually work to the project if only as a massive diff of minor bits.

[ftruscot]

The main development is going on in the trunk and is a very unstable version of the upcoming 4.0 which will be multibyte and make use of additional php5 things.